ref: Move subprocess breadcrumbs to integration - #7128
Conversation
Move subprocess breadcrumb creation from the centralized `maybe_create_breadcrumbs_from_span` hook into the stdlib integration's `Popen.__init__` wrapper. This makes breadcrumbs work for both legacy spans and streamed spans, and removes the dependency on span internals.
Codecov Results 📊✅ 99250 passed | ⏭️ 6479 skipped | Total: 105729 | Pass Rate: 93.87% | Execution Time: 353m 0s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2501 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.96% 89.99% +0.03%
==========================================
Files 193 193 —
Lines 24975 24974 -1
Branches 9010 9008 -2
==========================================
+ Hits 22467 22473 +6
- Misses 2508 2501 -7
- Partials 1437 1437 —Generated by Codecov Action |
sentrivana
changed the title
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ea13df. Configure here.
|
|
||
| env = None | ||
|
|
||
| with capture_internal_exceptions(): |
There was a problem hiding this comment.
this wasn't in a try...except before as far as I can tell, so probably okay to go without a capture_internal_exceptions(), but doesn't really matter.
### Description Decouple subprocess breadcrumbs from span data. #### Issues Closes getsentry#7068
2 participants
Description
Decouple subprocess breadcrumbs from span data.
Issues
Closes #7068